upgrading ledger goclient lib #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this change and it restore ledger app functionality on my mac |
Codecov Report
@@ Coverage Diff @@
## develop #1995 +/- ##
========================================
Coverage 64.86% 64.86%
========================================
Files 115 115
Lines 6862 6862
========================================
Hits 4451 4451
Misses 2127 2127
Partials 284 284 |
|
@jleni I can't push to your branch - this looks fine but can you also run |
Merged
cwgoes
pushed a commit
that referenced
this pull request
Aug 13, 2018
ebuchman
pushed a commit
that referenced
this pull request
Aug 13, 2018
* Set SignedBlocksWindow back to 1000 * Merge PR #1995: upgrading ledger goclient lib * Update version/version.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required when using the ledger app version 0.1.1